Leaf-WAI/StackLayoutManager
1
0
Fork 0
mirror of https://github.com/leaf-wai/StackLayoutManager.git synced 2026-07-13 03:11:19 +08:00
Code Issues Projects Releases Wiki Activity

Fix on items not being removed and crash on scroll

Browse Source
This commit is contained in:
Dániel Zolnai
2018-09-03 12:46:58 +02:00
parent 2aa6d64a81
commit 81be937cdb
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
StackLayoutManager/src/main/java/com/littlemango/stacklayoutmanager/StackLayoutManager.kt
View File

@@ -264,6 +264,9 @@ class StackLayoutManager(scrollOrientation: ScrollOrientation,
} }
override fun canScrollHorizontally(): Boolean { override fun canScrollHorizontally(): Boolean {
if (itemCount == 0) {
return false
}
return when (mScrollOrientation) { return when (mScrollOrientation) {
ScrollOrientation.LEFT_TO_RIGHT, ScrollOrientation.RIGHT_TO_LEFT -> true ScrollOrientation.LEFT_TO_RIGHT, ScrollOrientation.RIGHT_TO_LEFT -> true
else -> false else -> false
@@ -271,6 +274,9 @@ class StackLayoutManager(scrollOrientation: ScrollOrientation,
} }
override fun canScrollVertically(): Boolean { override fun canScrollVertically(): Boolean {
if (itemCount == 0) {
return false
}
return when (mScrollOrientation) { return when (mScrollOrientation) {
ScrollOrientation.TOP_TO_BOTTOM, ScrollOrientation.BOTTOM_TO_TOP -> true ScrollOrientation.TOP_TO_BOTTOM, ScrollOrientation.BOTTOM_TO_TOP -> true
else -> false else -> false
@@ -278,18 +284,16 @@ class StackLayoutManager(scrollOrientation: ScrollOrientation,
} }
override fun onLayoutChildren(recycler: RecyclerView.Recycler, state: RecyclerView.State) { override fun onLayoutChildren(recycler: RecyclerView.Recycler, state: RecyclerView.State) {
if (itemCount == 0) {
return
}
mLayout?.requestLayout() mLayout?.requestLayout()
removeAndRecycleAllViews(recycler) removeAndRecycleAllViews(recycler)
if (itemCount > 0) {
mScrollOffset = getValidOffset(mScrollOffset) mScrollOffset = getValidOffset(mScrollOffset)
loadItemView(recycler) loadItemView(recycler)
} }
}
override fun scrollHorizontallyBy(dx: Int, recycler: RecyclerView.Recycler, state: RecyclerView.State): Int { override fun scrollHorizontallyBy(dx: Int, recycler: RecyclerView.Recycler, state: RecyclerView.State): Int {
return handleScrollBy(dx, recycler) return handleScrollBy(dx, recycler)