fix: 处理部分 SonarQube 问题

This commit is contained in:
chenjuntao
2022-08-02 16:22:45 +08:00
parent c8cd753022
commit 9c11f7f70e
13 changed files with 75 additions and 132 deletions

View File

@ -30,7 +30,7 @@ public class DetailDownloadUtils {
public static void detailInitDownload(DetailViewHolder viewHolder, boolean isCheck) {
String downloadAddWord = viewHolder.gameEntity.getDownloadAddWord();
viewHolder.overlayTv.setVisibility(View.GONE);
viewHolder.getOverlayTv().setVisibility(View.GONE);
if (viewHolder.gameEntity != null
&& Config.isShowDownload(viewHolder.gameEntity.getId())
@ -75,7 +75,7 @@ public class DetailDownloadUtils {
String downloadText;
if (viewHolder.context.getString(R.string.launch).equals(status) || viewHolder.context.getString(R.string.install).equals(status) || viewHolder.context.getString(R.string.download).equals(status)) {
downloadText = "";
viewHolder.overlayTv.setVisibility(View.VISIBLE);
viewHolder.getOverlayTv().setVisibility(View.VISIBLE);
} else if (viewHolder.context.getString(R.string.attempt).equals(status)) {
downloadText = status + getDownloadSizeText(viewHolder);
} else {
@ -191,7 +191,7 @@ public class DetailDownloadUtils {
}
viewHolder.mDownloadPb.setProgress((int) (viewHolder.downloadEntity.getPercent() * 10));
viewHolder.overlayTv.setVisibility(View.GONE);
viewHolder.getOverlayTv().setVisibility(View.GONE);
if (viewHolder.gameEntity.isVGame()) {
updateVStyleButton(viewHolder);
@ -247,7 +247,7 @@ public class DetailDownloadUtils {
}
viewHolder.mDownloadPb.setText("");
viewHolder.overlayTv.setVisibility(View.VISIBLE);
viewHolder.getOverlayTv().setVisibility(View.VISIBLE);
}
} else {
if (SPUtils.getBoolean(Constants.SP_USE_BROWSER_TO_INSTALL)) {
@ -305,18 +305,9 @@ public class DetailDownloadUtils {
}
viewHolder.mDownloadPb.setText("");
viewHolder.overlayTv.setVisibility(View.VISIBLE);
break;
viewHolder.getOverlayTv().setVisibility(View.VISIBLE);
}
case cancel:
case hijack:
case notfound:
case uncertificated:
case unqualified:
case unavailable:
// TODO 检查不调用 detailInitDownload 会有什么影响
// detailInitDownload(viewHolder, false);
// break;
break;
default:
break;
}